Skip to content

security: account association #22817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

security: account association #22817

wants to merge 9 commits into from

Conversation

@sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Jun 10, 2025 •
edited
Loading

Do not merge! Holding off on docs until fully GA ~2 weeks from Jun 17

Description

  • Adds manual "Manage unassociated machines" to Security section
  • Summary bar updates and landing page

Preview links

Related issues or tickets

https://docker.atlassian.net/browse/ENGDOCS-2542

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Jun 10, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9fcba83
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/685173bfe977bf0008a80f6e
😎 Deploy Preview https://deploy-preview-22817--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sarahsanders-docker sarahsanders-docker added the area/admin Relates to Docker Admin label Jun 11, 2025
@sarahsanders-docker sarahsanders-docker requested a review from a team June 11, 2025 15:35
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review June 11, 2025 15:35
@sarahsanders-docker sarahsanders-docker changed the title draft: account association security: account association Jun 11, 2025
smnovick
smnovick previously requested changes Jun 11, 2025
View reviewed changes
Copy link

@smnovick smnovick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahsanders-docker Left a bunch of feedback.

It might actually make sense to craete a new page for developers to explain "why is docker desktop" requiring me to login (in addition to this work) - we can list out all the different cases of why they are being required to sign in.

@sarahsanders-docker
Copy link
Contributor Author

sarahsanders-docker commented Jun 12, 2025

@sarahsanders-docker Left a bunch of feedback.

It might actually make sense to craete a new page for developers to explain "why is docker desktop" requiring me to login (in addition to this work) - we can list out all the different cases of why they are being required to sign in.

maybe we add it here? https://docs.docker.com/desktop/setup/sign-in/

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Jun 12, 2025
usha-mandya
usha-mandya reviewed Jun 17, 2025
View reviewed changes
usha-mandya
usha-mandya reviewed Jun 17, 2025
View reviewed changes
usha-mandya
usha-mandya reviewed Jun 17, 2025
View reviewed changes
@usha-mandya
Copy link
Member

usha-mandya commented Jun 17, 2025

PR looks good @sarahsanders-docker. Added some minor comments. Let me know if you have any questions.

@sarahsanders-docker sarahsanders-docker added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Jun 17, 2025
@sarahsanders-docker sarahsanders-docker requested a review from a team June 17, 2025 15:41
@sarahsanders-docker sarahsanders-docker deleted the account-association branch July 29, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aevesdocker aevesdocker Awaiting requested review from aevesdocker aevesdocker is a code owner

@smnovick smnovick Awaiting requested review from smnovick

@usha-mandya usha-mandya Awaiting requested review from usha-mandya

Assignees

No one assigned

Labels

area/admin Relates to Docker Admin area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/tests status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. status/review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarahsanders-docker @usha-mandya @smnovick